LemMinX-Maven 0.10.1 + Lemminx 0.27.0 + WWD 1.3.0 #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrubezhny
force-pushed
the
use-LemminxMaven-0.10.0
branch
from
05dc64e
to
4762660
Compare
vrubezhny
force-pushed
the
use-LemminxMaven-0.10.0
branch
3 times, most recently
from
8560a6e
to
d26f440
Compare
vrubezhny
changed the title
vrubezhny
force-pushed
the
use-LemminxMaven-0.10.0
branch
2 times, most recently
from
9394342
to
af8d12b
Compare
vrubezhny
force-pushed
the
use-LemminxMaven-0.10.0
branch
from
af8d12b
to
a013001
Compare
|
@vrubezhny you marked this a WIP what needs to be done here before it can be merged? |
Looks like there used to be some test-failures, but now the build is green. Mac currently always fails. |
|
@laeubi @HannesWell There were m2e Editor failures due to the recent changes in Lemminx and Lemminx-maven extension. Now the JUnit tests pass with success (even for the failing MacOS runner). So I would merge the PR and after that we're waiting a m2e-core version to be promoted to SimRel. |
HannesWell
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.